fix: change error for invalid feature param in feature RPC
#5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
force-pushed
the
bad-feature
branch
2 times, most recently
from
11d072c to
846dcf3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5063 +/- ##
=========================================
- Coverage 71.4% 71.4% -0.0%
=========================================
Files 796 796
Lines 67039 67042 +3
Branches 10864 10864
=========================================
+ Hits 47844 47846 +2
- Misses 19195 19196 +1
... and 5 files with indirect coverage changes |
godexsoft
approved these changes
Jul 12, 2024
intelliot
approved these changes
Jul 24, 2024
|
This is ready to merge. |
ximinez
added
the
Passed
vlntb
pushed a commit
to vlntb/rippled
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR changes the error message for invalid values of
featurein thefeatureRPC. Now, if a non-string is passed into the function, it will returninvalidParams, instead ofbadFeatureas it did before.Context of Change
In rippled 2.2.0, a non-admin version of
featurewas added. This makes the need for proper error handling more important.Type of Change
API Impact
While this is technically a breaking change, I consider it more of a bugfix. Only the error message is changing.
Test Plan
Additional unit tests were added.